ENH Check canViewFile permissions before automatically grant access

[sabina-talipova]

Description

Add condition to check if user has access to view the file and only then give him a session grant access to the file.

Parent Issue

• Change the default on File Grant #501

[emteknetnz]

There's some broken unit tests in CI - however they relate to this #518 (comment)

Did you identify any content editing experiences that are likely to break because of this change?

[emteknetnz]

Suggested change

	if ($this->File->canViewFile()) {
	$grant = true;
	}
	if (!$grant && $this->canView()) {
	$grant = true;
	}

[emteknetnz]

Is there any reason why we'd use $this->File->canViewFile() over regular $this->canView()?

We should also perform a !$grant check first to prevent unnecessary logic

[sabina-talipova]

DONE

[emteknetnz]

Suggested change

	if ($this->File->canViewFile()) {
	$grant = true;
	}
	if (!$grant && $this->canView()) {
	$grant = true;
	}

[sabina-talipova]

DONE

[emteknetnz]

@sabina-talipova Did you identify any content editing experiences that are likely to break because of this change?

[sabina-talipova]

@emteknetnz , I did a few tests in Page section, Submission section on UserFormPage and Files section. And I also tested DRAFT content on Published and Unpublished pages. I haven't found any problem with Content or UI.
If user has "Access to Page section" he will have an access to the File.