Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Fix deprecation issues for PHP 8.1 compatibility #484

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

emteknetnz
Copy link
Member

Issue silverstripe/silverstripe-framework#10250

Fixes following deprecation warnings during unit tests

Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/vendor/intervention/image/src/Intervention/Image/Gd/Font.php on line 232

Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/vendor/intervention/image/src/Intervention/Image/Gd/Font.php on line 243

Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emteknetnz emteknetnz merged commit a850ecc into silverstripe:1 Apr 6, 2022
@emteknetnz emteknetnz deleted the pulls/1/php81-manual branch April 6, 2022 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants