MNT PHP 8.1

src/Dev/Tasks/FileMigrationHelper.php

@@ -210,7 +210,7 @@ protected function ss3Migration($base)
      * If `$initialStrategy` is not suitable for a migration, we return null.
      * We're overriding the helpers to avoid doing unnecessary checks.
      * @param FileResolutionStrategy $initialStrategy
-     * @return int|FileIDHelperResolutionStrategy
+     * @return int|FileIDHelperResolutionStrategy|null
      */
     private function buildSS3MigrationStrategy(FileResolutionStrategy $initialStrategy)
     {

src/Dev/TestAssetStore.php

@@ -105,7 +105,7 @@ public static function activate($basedir)
     /**
      * Get absolute path to basedir
      *
-     * @return string
+     * @return string|null
      */
     public static function base_path()
     {

src/File.php

@@ -609,7 +609,7 @@ public function getStatusTitle()
      * Possible group values are: "audio", "mov", "zip", "image".
      *
      * @param string $ext Extension to check
-     * @return string
+     * @return string|false
      */
     public static function get_app_category($ext)
     {
@@ -732,7 +732,7 @@ protected function onBeforeWrite()
             // and any file extensions removed.
             $this->setField(
                 'Title',
-                str_replace(['-','_'], ' ', preg_replace('/\.[^.]+$/', '', $name))
+                str_replace(['-','_'], ' ', preg_replace('/\.[^.]+$/', '', $name) ?: '')
             );
         }
 
@@ -872,7 +872,7 @@ protected function getNameGenerator($filename)
     /**
      * Gets the URL of this file
      *
-     * @return string
+     * @return string|null
      */
     public function getAbsoluteURL()
     {
@@ -888,7 +888,7 @@ public function getAbsoluteURL()
      *
      * @uses Director::baseURL()
      * @param bool $grant Ensures that the url for any protected assets is granted for the current user.
-     * @return string
+     * @return string|null
      */
     public function getURL($grant = true)
     {
@@ -902,7 +902,7 @@ public function getURL($grant = true)
      * Get URL, but without resampling.
      *
      * @param bool $grant Ensures that the url for any protected assets is granted for the current user.
-     * @return string
+     * @return string|null
      */
     public function getSourceURL($grant = true)
     {
@@ -1019,7 +1019,7 @@ public static function get_file_extension($filename)
      * Given an extension, determine the icon that should be used
      *
      * @param string $extension
-     * @return string Icon filename relative to base url
+     * @return string|null Icon filename relative to base url
      */
     public static function get_icon_for_extension($extension)
     {

src/FilenameParsing/FileIDHelperResolutionStrategy.php

@@ -523,7 +523,7 @@ public function stripVariant($fileID)
      *
      * @param ParsedFileID $parsedFileID
      * @param FileIDHelper $helper
-     * @return ParsedFileID
+     * @return ParsedFileID|null
      */
     private function stripVariantFromParsedFileID(ParsedFileID $parsedFileID, FileIDHelper $helper)
     {

src/FilenameParsing/LegacyFileIDHelper.php

@@ -133,7 +133,7 @@ public function parseFileID($fileID)
         return new ParsedFileID(
             $filename,
             '',
-            isset($matches['variant']) ? str_replace('/', '_', $matches['variant']) : '',
+            isset($matches['variant']) ? str_replace('/', '_', $matches['variant'] ?: '') : '',
             $fileID
         );
     }

src/Folder.php

@@ -238,7 +238,7 @@ public function getURL($grant = true)
     /**
      * Folders do not have public URLs
      *
-     * @return string
+     * @return string|null
      */
     public function getAbsoluteURL()
     {

src/ImageManipulation.php

@@ -1024,7 +1024,7 @@ public function variantParts($variantName)
 
         // Regex needs to be case insensitive since allMethodNames() is all lowercased
         $regex = '#^(?<format>(' . implode('|', $methods) . '))(?<encodedargs>(.*))#i';
-        preg_match($regex, $variantName, $matches);
+        preg_match($regex, (string) $variantName, $matches);
 
         if (!$matches) {
             throw new InvalidArgumentException('Invalid variant name: ' . $variantName);

src/InterventionBackend.php

@@ -214,7 +214,7 @@ public function loadFromContainer(AssetContainer $assetContainer)
      * Get the currently assigned image resource, or generates one if not yet assigned.
      * Note: This method may return null if error
      *
-     * @return InterventionImage
+     * @return InterventionImage|null
      */
     public function getImageResource()
     {
@@ -351,7 +351,7 @@ public function setImageResource($image)
      * @param string $hash Hash of original file, if storing a variant.
      * @param string $variant Name of variant, if storing a variant.
      * @param array $config Write options. {@see AssetStore}
-     * @return array Tuple associative array (Filename, Hash, Variant) Unless storing a variant, the hash
+     * @return array|null Tuple associative array (Filename, Hash, Variant) Unless storing a variant, the hash
      * will be calculated from the given data.
      * @throws BadMethodCallException If image isn't valid
      */

src/Shortcodes/FileShortcodeProvider.php

@@ -70,7 +70,7 @@ public static function get_shortcodes()
      * @param string $shortcode Name of shortcode used to register this handler
      * @param array $extra Extra arguments
      *
-     * @return string Result of the handled shortcode
+     * @return string|null Result of the handled shortcode
      */
     public static function handle_shortcode($arguments, $content, $parser, $shortcode, $extra = [])
     {
@@ -202,7 +202,7 @@ public static function find_shortcode_record($args, &$errorCode = null)
      *
      * @param int $errorCode HTTP Error value
      *
-     * @return File|SiteTree File or SiteTree object to use for the given error
+     * @return File|SiteTree|null File or SiteTree object to use for the given error
      */
     protected static function find_error_record($errorCode)
     {

src/Storage/DBFile.php

@@ -151,7 +151,7 @@ public function getTag()
     /**
      * Determine the template to render as on the frontend
      *
-     * @return string Name of template
+     * @return string|null Name of template
      */
     public function getFrontendTemplate()
     {
@@ -173,7 +173,7 @@ public function getFrontendTemplate()
     /**
      * Get trailing part of filename
      *
-     * @return string
+     * @return string|null
      */
     public function getBasename()
     {
@@ -186,7 +186,7 @@ public function getBasename()
     /**
      * Get file extension
      *
-     * @return string
+     * @return string|null
      */
     public function getExtension()
     {
@@ -318,7 +318,7 @@ public function getSourceURL($grant = true)
     /**
      * Get the absolute URL to this resource
      *
-     * @return string
+     * @return string|null
      */
     public function getAbsoluteURL()
     {

src/Storage/DefaultAssetNameGenerator.php

@@ -100,7 +100,7 @@ public function __construct($filename)
             $this->name = $matches['name'];
             // Check if number is padded
             if (strpos($matches['version'], '0') === 0) {
-                $this->padding = strlen($matches['version']);
+                $this->padding = strlen((string) $matches['version']);
             }
         } else {
             $this->first = 1;

src/Storage/ProtectedFileController.php

@@ -75,7 +75,7 @@ public function handleFile(HTTPRequest $request)
     public function isValidFilename($filename)
     {
         // Block hidden files
-        return !preg_match('#(^|[\\\\/])\\..*#', $filename);
+        return !preg_match('#(^|[\\\\/])\\..*#', (string) $filename);
     }
 
     /**

tests/php/RedirectFileControllerTest.php

@@ -530,7 +530,7 @@ protected function assertResponse($code, $body, $location, HTTPResponse $respons
      */
     protected function normaliseUrl($path)
     {
-        return str_replace('RedirectFileControllerTest/', '', $path);
+        return str_replace('RedirectFileControllerTest/', '', $path ?: '');
     }
 
     public function get($url, $session = null, $headers = null, $cookies = null)