-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW WebP support in CMS #476
NEW WebP support in CMS #476
Conversation
Can we extend or adjust an existing test adding the webp support there, too? |
If we're concerned about content authors accidentally adding WepP image to site targetting IE11 users, we could just put this in a separate module which would allow project to opt-in to webp support. Looking at the statcounter, IE11 has a global market share right now of 0.45%. And it's dropping rapidly ... it was 0.81% a year ago. I'm thinking, most sites that still want to cater to IE11 users will probably be well aware not to use WebP images any way. We can probably address this with some user docs. So it's basically making life somewhat better for the vast majority of project with a tiny risk that someone will accidentally publish a WebP image to a site that still support IE11. @silverstripe/core-team Yeah 👍 Nay 👎 on merging this PR? |
b4d36aa
to
1ce0018
Compare
IMO add support by default, and provide a config flag so that developers can turn it off on sites that require IE11 support |
1ce0018
to
9ba3ad4
Compare
I tested to make sure this works with Imagick, which it does. I also validated that you can block webp file upload by adding snippet to your YML config: SilverStripe\Assets\File:
allowed_extensions:
webp: false Found a related bug here: silverstripe/silverstripe-asset-admin#1256 |
This PR adds support for WebP images. The CMS will essentially treat them like JPEG and PNG images.
Please note: