API Stop using deprecated API

silverstripe · Nov 15, 2022 · f59e1f0 · f59e1f0
1 parent aeca7ea
commit f59e1f0
Show file tree

Hide file tree

Showing 24 changed files with 515 additions and 28 deletions.
diff --git a/src/Dev/Tasks/FileMigrationHelper.php b/src/Dev/Tasks/FileMigrationHelper.php
@@ -62,7 +62,9 @@ class FileMigrationHelper
 
     public function __construct()
     {
-        Deprecation::notice('1.12.0', 'Will be removed without equivalent functionality to replace it', Deprecation::SCOPE_CLASS);
+        Deprecation::withNoReplacement(function () {
+            Deprecation::notice('1.12.0', 'Will be removed without equivalent functionality to replace it', Deprecation::SCOPE_CLASS);
+        });
         $this->logger = new NullLogger();
     }
 

diff --git a/src/Dev/Tasks/NormaliseAccessMigrationHelper.php b/src/Dev/Tasks/NormaliseAccessMigrationHelper.php
@@ -91,7 +91,9 @@ class NormaliseAccessMigrationHelper
      */
     public function __construct($base = '')
     {
-        Deprecation::notice('1.12.0', 'Will be removed without equivalent functionality to replace it', Deprecation::SCOPE_CLASS);
+        Deprecation::withNoReplacement(function () {
+            Deprecation::notice('1.12.0', 'Will be removed without equivalent functionality to replace it', Deprecation::SCOPE_CLASS);
+        });
         $this->logger = new NullLogger();
         if ($base) {
             $this->basePath = $base;

diff --git a/src/Dev/TestAssetStore.php b/src/Dev/TestAssetStore.php
@@ -90,8 +90,7 @@ public static function activate($basedir)
         Injector::inst()->registerService($generated, GeneratedAssetHandler::class);
         Requirements::backend()->setAssetHandler($generated);
 
-        // Disable legacy and set defaults
-        FlysystemAssetStore::config()->set('legacy_filenames', false);
+        // Set defaults
         Director::config()->set('alternate_base_url', '/');
         DBFile::config()->set('force_resample', false);
         File::config()->set('force_resample', false);

diff --git a/src/FileMigrationHelper.php b/src/FileMigrationHelper.php
@@ -1,5 +1,9 @@
 <?php
 
+/**
+ * @see FileMigrationHelper class
+ * @deprecated 1.12.0 Will be removed without equivalent functionality to replace it
+ */
 use SilverStripe\Assets\Dev\Tasks\FileMigrationHelper;
 
 if (!class_exists('SilverStripe\\Assets\\FileMigrationHelper')) {

diff --git a/src/FilenameParsing/LegacyFileIDHelper.php b/src/FilenameParsing/LegacyFileIDHelper.php
@@ -54,7 +54,13 @@ class LegacyFileIDHelper implements FileIDHelper
      */
     public function __construct($failNewerVariant = true)
     {
-        Deprecation::notice('1.12.0', 'Legacy file names will not be supported in Silverstripe CMS 5', Deprecation::SCOPE_CLASS);
+        Deprecation::withNoReplacement(function () {
+            Deprecation::notice(
+                '1.12.0',
+                'Legacy file names will not be supported in Silverstripe CMS 5',
+                Deprecation::SCOPE_CLASS
+            );
+        });
         $this->failNewerVariant = $failNewerVariant;
     }
 

diff --git a/src/ImageBackendFactory.php b/src/ImageBackendFactory.php
@@ -37,21 +37,21 @@ public function __construct(Factory $creator)
      */
     public function create($service, array $params = [])
     {
-        /** @var AssetContainer */
-        $store = reset($params);
-        if (!$store instanceof AssetContainer) {
+        /** @var AssetContainer $assetContainer */
+        $assetContainer = reset($params);
+        if (!$assetContainer instanceof AssetContainer) {
             throw new BadMethodCallException("Can only create Image_Backend for " . AssetContainer::class);
         }
 
         // Check cache
-        $key = sha1($store->getHash().'-'.$store->getVariant());
+        $key = sha1($assetContainer->getHash().'-'.$assetContainer->getVariant());
         if (array_key_exists($key, $this->cache ?? [])) {
             return $this->cache[$key];
         }
 
         // Verify file exists before creating backend
         $backend = null;
-        if ($store->exists() && $store->getIsImage()) {
+        if ($assetContainer->exists() && $assetContainer->getIsImage()) {
             $backend = $this->creator->create($service, $params);
         }
 

diff --git a/src/Upload_Validator.php b/src/Upload_Validator.php
@@ -2,6 +2,7 @@
 
 namespace SilverStripe\Assets;
 
+use SilverStripe\Core\Convert;
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Core\Config\Configurable;
 use SilverStripe\Core\Injector\Injectable;
@@ -121,8 +122,8 @@ public function getAllowedMaxFileSize($ext = null)
                 $this->setAllowedMaxFileSize($fileSize);
             } else {
                 // When no default is present, use maximum set by PHP
-                $maxUpload = File::ini2bytes(ini_get('upload_max_filesize'));
-                $maxPost = File::ini2bytes(ini_get('post_max_size'));
+                $maxUpload = Convert::memstring2bytes(ini_get('upload_max_filesize'));
+                $maxPost = Convert::memstring2bytes(ini_get('post_max_size'));
                 $this->setAllowedMaxFileSize(min($maxUpload, $maxPost));
             }
         }
@@ -165,15 +166,15 @@ public function setAllowedMaxFileSize($rules)
                 if (is_numeric($value)) {
                     $tmpSize = $value;
                 } else {
-                    $tmpSize = File::ini2bytes($value);
+                    $tmpSize = Convert::memstring2bytes($value);
                 }
 
                 $finalRules[$rule] = (int)$tmpSize;
             }
 
             $this->allowedMaxFileSize = $finalRules;
         } elseif (is_string($rules)) {
-            $this->allowedMaxFileSize['*'] = File::ini2bytes($rules);
+            $this->allowedMaxFileSize['*'] = Convert::memstring2bytes($rules);
         } elseif ((int)$rules > 0) {
             $this->allowedMaxFileSize['*'] = (int)$rules;
         }

diff --git a/tests/php/Dev/Tasks/FileMigrationHelperTest.php b/tests/php/Dev/Tasks/FileMigrationHelperTest.php
@@ -18,8 +18,7 @@
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Core\Convert;
 use SilverStripe\Core\Injector\Injector;
-use SilverStripe\Dev\SapphireTest;
-use SilverStripe\ORM\Queries\SQLUpdate;
+use SilverStripe\Dev\Deprecation;
 
 /**
  * Ensures that File dataobjects can be safely migrated from 3.x
@@ -176,6 +175,9 @@ protected function tearDown(): void
      */
     public function testMigration()
     {
+        if (Deprecation::isEnabled()) {
+            $this->markTestSkipped('Test calls deprecated code');
+        }
         $this->preCondition();
 
         // The EXE file, extensionless file and missing file won't be migrated
@@ -428,6 +430,9 @@ private function missingFiles()
      */
     public function testMigrationWithLegacyFilenames()
     {
+        if (Deprecation::isEnabled()) {
+            $this->markTestSkipped('Test calls deprecated code');
+        }
         Config::modify()->set(FlysystemAssetStore::class, 'legacy_filenames', true);
         $this->testMigration();
     }
@@ -438,6 +443,9 @@ public function testMigrationWithLegacyFilenames()
      */
     public function testInvalidAssetStoreStrategy()
     {
+        if (Deprecation::isEnabled()) {
+            $this->markTestSkipped('Test calls deprecated code');
+        }
         $strategy = FileIDHelperResolutionStrategy::create();
         $strategy->setDefaultFileIDHelper(new HashFileIDHelper());
         $strategy->setResolutionFileIDHelpers([new HashFileIDHelper()]);

diff --git a/tests/php/Dev/Tasks/FixFolderPermissionsHelperTest.php b/tests/php/Dev/Tasks/FixFolderPermissionsHelperTest.php
@@ -3,6 +3,7 @@
 namespace SilverStripe\Assets\Tests\Dev\Tasks;
 
 use SilverStripe\Assets\Folder;
+use SilverStripe\Dev\Deprecation;
 use SilverStripe\Dev\SapphireTest;
 use SilverStripe\Dev\Tasks\FixFolderPermissionsHelper;
 
@@ -15,6 +16,9 @@ class FixFolderPermissionsHelperTest extends SapphireTest
 
     public function testTask()
     {
+        if (Deprecation::isEnabled()) {
+            $this->markTestSkipped('Test calls deprecated code');
+        }
         $task = new FixFolderPermissionsHelper();
         $updated = $task->run();
 

diff --git a/tests/php/Dev/Tasks/LegacyThumbnailMigrationHelperTest.php b/tests/php/Dev/Tasks/LegacyThumbnailMigrationHelperTest.php
@@ -11,6 +11,7 @@
 use SilverStripe\Assets\Storage\AssetStore;
 use SilverStripe\Assets\Tests\Dev\Tasks\FileMigrationHelperTest\Extension;
 use SilverStripe\Core\Convert;
+use SilverStripe\Dev\Deprecation;
 use SilverStripe\Dev\SapphireTest;
 
 class LegacyThumbnailMigrationHelperTest extends SapphireTest
@@ -73,6 +74,9 @@ protected function tearDown(): void
      */
     public function testMigratesWithExistingThumbnailInNewLocation($coreVersion)
     {
+        if (Deprecation::isEnabled()) {
+            $this->markTestSkipped('Test calls deprecated code');
+        }
         /** @var TestAssetStore $store */
         $store = singleton(AssetStore::class); // will use TestAssetStore
 
@@ -105,6 +109,9 @@ public function testMigratesWithExistingThumbnailInNewLocation($coreVersion)
      */
     public function testMigratesMultipleFilesInSameFolder($coreVersion)
     {
+        if (Deprecation::isEnabled()) {
+            $this->markTestSkipped('Test calls deprecated code');
+        }
         /** @var TestAssetStore $store */
         $store = singleton(AssetStore::class); // will use TestAssetStore
 
@@ -148,6 +155,9 @@ public function testMigratesMultipleFilesInSameFolder($coreVersion)
      */
     public function testMigrate($fixtureId, $formats, $coreVersion)
     {
+        if (Deprecation::isEnabled()) {
+            $this->markTestSkipped('Test calls deprecated code');
+        }
         /** @var TestAssetStore $store */
         $store = singleton(AssetStore::class); // will use TestAssetStore