MINOR Open file details after the last file has been uploaded #808
Conversation
There was a problem hiding this comment.
The WYSIWYG part seems to be working fine. However looks like there's been some regression on the File management UI.
If I upload a file via the file management interface and delete it right away, it's still visible until I refresh the page (the behat failure is legit in this case).
If I check back the 1 branch, it works fine.
| @@ -309,26 +309,6 @@ describe('Gallery', () => { | |||
| expect(props.actions.queuedFiles.removeQueuedFile).not.toBeCalled(); | |||
| }); | |||
|
|
|||
| it('should openFile if type is "insert-media"', () => { | |||
There was a problem hiding this comment.
Why are those tests no longer relevant?
There was a problem hiding this comment.
Because we decided that it should open the uploaded file on both views (asset-admin and insert media) so we no longer check for that.
There was a problem hiding this comment.
Cool. Just wanted to make sure.
|
@maxime-rainville Turns out the failing test wasn't actually related to my change (it was failing locally for me on |
There was a problem hiding this comment.
I pull your changes down, and I'm still seeing the same behavior. https://youtu.be/c8ZVXdeHKLY
But after playing with the 1 branch, I can see it has a similar problem. The only difference is that you can delete the file correctly if you don't select the detail view after upload. https://youtu.be/jhjSh3qZOw4
I'm happy to merge it as-is and raise a separate issue
There was a problem hiding this comment.
I'm still seeing the broken behavior on the PR branch, but after further inspection, I can see a similar behavior on the 1 branch as well.
- 1 branch https://youtu.be/jhjSh3qZOw4
- PR branch https://www.youtube.com/watch?v=c8ZVXdeHKLY&feature=youtu.be
The only difference is that on the 1 branch, the file can be deleted immediately after upload as long as you don't look at the details of the file.
I'm OK merging this as-is and raise a separate issue if you don't think it's worth fixing it now.
|
Sorry I'm repeating myself :-P |
|
I've created #809 about the ghost entry. |
Fixes #489