ENH Allow URLs without trailing slashes #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
GuySartorelli
force-pushed
the
pulls/2/no-trailing-slash
branch
2 times, most recently
from
9038589 to
420f31a
Compare
GuySartorelli
force-pushed
the
pulls/2/no-trailing-slash
branch
from
420f31a to
58b77cd
Compare
|
webpack-config changes are now included in this PR. |
|
Rebased to resolve conflicts |
GuySartorelli
force-pushed
the
pulls/2/no-trailing-slash
branch
from
58b77cd to
447beaa
Compare
emteknetnz
approved these changes
Jan 20, 2023
|
Failing JS tests are going to be dealt with in silverstripe/silverstripe-admin#1421 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
silverstripe/silverstripe-framework#10538 allows us to have a URLs which can be configured to have or omit trailing slashes. This PR updates the asset-admin javascript to stop explicitly expecting one to be/not be there.
Note that this PR will need to be modified once silverstripe/webpack-config#57 has been merged and released in NPM.
Parent issue