Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ignore_menuitem into LeftAndMain #1846

Merged

Conversation

catharsisjelly
Copy link
Contributor

@catharsisjelly catharsisjelly commented Nov 1, 2024

Description

Adds the configuration ignore_menuitem into LeftAndMain so that anyone looking at the class will knows that this configuration exists. This will also now show up in the API docs (I think).

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@catharsisjelly catharsisjelly force-pushed the issue-1845-ignore_menuitem branch from 604b752 to 32730a8 Compare November 1, 2024 16:49
@catharsisjelly
Copy link
Contributor Author

This is aimed to fix it in the main branch, happy to rebase it to another if needed. It could be also implemented in 1.x

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. You've got the correct branch - new API definitions belong in minor releases, and the 2 branch represents the April 2025 minor release currently.

code/LeftAndMain.php Outdated Show resolved Hide resolved
code/LeftAndMain.php Outdated Show resolved Hide resolved
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this.
Will merge once CI has finished running and goes green.

@GuySartorelli
Copy link
Member

There's a linting failure related to your change. Can you please resolve that?

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this.

@GuySartorelli GuySartorelli merged commit fbeface into silverstripe:2 Nov 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants