-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Stop refering to "pages" when dealing with generic records #1837
base: 3
Are you sure you want to change the base?
API Stop refering to "pages" when dealing with generic records #1837
Conversation
3e495f0
to
456360d
Compare
456360d
to
87954c0
Compare
CMSMain::class . '.ACCESS', | ||
LeftAndMain::class . '.ACCESS', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CMSMain doesn't even exist if you're installing silverstripe/admin without silverstripe/cms. LeftAndMain
is the obvious choice here.
'category' => _t(Permission::class . '.CMS_ACCESS_CATEGORY', 'CMS Access'), | ||
'category' => _t(LeftAndMain::class . '.CMS_ACCESS_CATEGORY', 'CMS Access'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This belongs on LeftAndMain
as it goes hand-in-hand with the one above.
Two commits here:
DataObject
class, and adds a newgetModelClass()
method toLeftAndMain
. This standardises that method betweenModelAdmin
andCMSMain
and will be used extensively in the follow-up refactor cards in this epic.LeftAndMain
. Found this because I had to review all i18n strings inCMSMain
anyway.Issue
SiteTree
inCMSMain
silverstripe-cms#2947