Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Remove GraphQL #1802

Merged
merged 1 commit into from
Sep 2, 2024
Merged

API Remove GraphQL #1802

merged 1 commit into from
Sep 2, 2024

Conversation

emteknetnz
Copy link
Member

Issue #1799

@emteknetnz emteknetnz mentioned this pull request Jul 30, 2024
Closed
11 tasks
@emteknetnz emteknetnz force-pushed the pulls/3/standardise-endpoints branch from 4e116a3 to 60bf964 Compare July 30, 2024 06:14
@emteknetnz emteknetnz changed the title API Standardise endpoints API Remove GraphQL Jul 30, 2024
@emteknetnz emteknetnz force-pushed the pulls/3/standardise-endpoints branch 3 times, most recently from f159cb1 to 74432d4 Compare August 2, 2024 12:30
@emteknetnz emteknetnz force-pushed the pulls/3/standardise-endpoints branch 4 times, most recently from 92113f0 to 5246f38 Compare August 13, 2024 04:46
@emteknetnz emteknetnz force-pushed the pulls/3/standardise-endpoints branch from 5246f38 to fbd1417 Compare August 16, 2024 05:10
@emteknetnz emteknetnz marked this pull request as ready for review August 19, 2024 22:13
GuySartorelli
GuySartorelli requested changes Aug 19, 2024
View reviewed changes
code/LeftAndMain.php Outdated Show resolved Hide resolved
code/LeftAndMain.php Show resolved Hide resolved
code/LeftAndMain.php Show resolved Hide resolved
code/LeftAndMain.php Outdated Show resolved Hide resolved
tests/php/LeftAndMainTest.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/3/standardise-endpoints branch 4 times, most recently from 063be20 to 47de853 Compare August 22, 2024 00:40
GuySartorelli
GuySartorelli approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when the other PRs are ready

@emteknetnz emteknetnz force-pushed the pulls/3/standardise-endpoints branch 5 times, most recently from 0daebf9 to 50dc89a Compare August 28, 2024 02:05
GuySartorelli
GuySartorelli approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approved most recent changes

@emteknetnz emteknetnz force-pushed the pulls/3/standardise-endpoints branch 2 times, most recently from 52418d1 to 7f98486 Compare August 30, 2024 00:05
GuySartorelli
GuySartorelli approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approved most recent changes

@GuySartorelli
Copy link
Member

Needs rebase

@emteknetnz emteknetnz force-pushed the pulls/3/standardise-endpoints branch from 7f98486 to 564166a Compare September 2, 2024 03:52
@emteknetnz
Copy link
Member Author

Done

@emteknetnz emteknetnz force-pushed the pulls/3/standardise-endpoints branch from 564166a to f6a42b6 Compare September 2, 2024 04:09
GuySartorelli
GuySartorelli approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit da42aa7 into silverstripe:3 Sep 2, 2024
14 checks passed
@GuySartorelli GuySartorelli deleted the pulls/3/standardise-endpoints branch September 2, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli