MNT Revert using map_get() for custom keys #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maxime-rainville should probably review this - I don't understand why he requested the original changes so there's clearly some context I'm missing here. |
|
I requested those changes because I thought the "proper way" to define different spacers is to reference Looking at the actual bootstrap source code. I think I was mistaken https://getbootstrap.com/docs/5.0/utilities/spacing/ Happy for this to be reverted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#34
Reverts some changes from cc63942#diff-5c0dc5481c744d9451ae984cb32defd734b765840cf78d2e54d0eadacd2c3d7dR224
Fixes https://github.com/silverstripe/silverstripe-login-forms/actions/runs/4559173620/jobs/8042886903
I ran yarn build and there were no changes to the bundle.css which is to be expected as the output is expected to be identical