Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Replacement for deprecated JQuery function activate #1471

Closed
wants to merge 1 commit into from
Closed

FIX Replacement for deprecated JQuery function activate #1471

wants to merge 1 commit into from

Conversation

sabina-talipova
Copy link
Contributor

Description

The activate method has been deprecated. It should be replaced to the activate method with calls to the option method to change the active option.
Official Upgrade guide

Parent issue

@sabina-talipova sabina-talipova mentioned this pull request Mar 15, 2023
Closed
@GuySartorelli GuySartorelli mentioned this pull request Mar 15, 2023
Closed
GuySartorelli
GuySartorelli requested changes Mar 15, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please target 1.12 for this one - anyone using CMS 4.12 has this problem right now, and 4.13 isn't stable so bug fixes should be targetting 4.12 branches

@sabina-talipova
Copy link
Contributor Author

CLOSE. Open PR for 1.12 #1472

@sabina-talipova sabina-talipova deleted the pulls/1.13/fix-accordion-issue branch March 15, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabina-talipova @GuySartorelli