FIX Correctly close spans for btn loading icon

[GuySartorelli]

The self-closing span tags were being incorrectly interpreted as nested spans, instead of sibling spans. This is most likely a result of the recent update of jQuery.

The correct HTML syntax for these is to not have them self-closing.

Parent issue

• CMS 4.12: btn-loading icon is broken in admin 1.12  #1426

[michalkleiner]

Looks ok, merge when you're happy with the tests, not sure if the failures are related or not. The change is fine on its own.

[GuySartorelli]

Rebased and rebuilt js - the actual change is unaltered.

[kinglozzer]

Running git diff
git diff found modified files when it should not have:
M js/bundle.js

Do we block merge for that? If not, feel free to self merge @GuySartorelli

[GuySartorelli]

We do, yeah. It means that when CI runs yarn build it's not getting the same results I got - in a community PR I'd be concerned they're trying to add something sneaky in there. In this PR I'm not sure what's causing it, but it's something that definitely needs resolving before we can merge.

[maxime-rainville]

@kinglozzer An attacker could try to build a bundle that doesn't match the PR and sneak a backdoor in the bundle.

[maxime-rainville]

I'm 90% sure the failure is a glitch. I forced another build, which will hopefully fix this.

[kinglozzer]

@GuySartorelli could you try rebuilding the bundle locally? CI checks are still failing 😞

[GuySartorelli]

I have tried that already (I think? I can't see it in the PR history though..... maybe my memory is playing tricks) but will try again. We've had this problem once before with one of Steve's PRs, and when I created an identical PR to try to debug it my PR didn't have this problem.... so if it doesn't work this time I'll try opening a new PR (in draft initially just to see if it works) - and failing that I guess someone can build it locally and do a diff to validate that they get the same results I push up?
We'll see.

[GuySartorelli]

There was a change when I yarn builded for some reason... not sure why but hopefully that fixes it.
Hurray for CI catching things yarn itself didn't.

[GuySartorelli]

This is finally green and already has two approvals. Self-merging.

[GuySartorelli]

@lekoala Released as 1.12.2