Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX overflow hidden from inactive chosen #1405

Conversation

emteknetnz
Copy link
Member

@michalkleiner
Copy link
Contributor

Why is the dist JS file being updated, do you know? Should it stay the same when only changing scss source file?

…12-release/remove-unneeded-security-fix

ENH Remove unnecessary workaround
@emteknetnz
Copy link
Member Author

User error :-)

@emteknetnz emteknetnz force-pushed the pulls/1.12-release/chosen-overflow branch from bd2f535 to 7fd2d80 Compare December 8, 2022 01:32
@GuySartorelli
Copy link
Member

@emteknetnz The change that's shown here for vendor.js is already present in this branch: https://github.com/silverstripe/silverstripe-admin/blob/1.12-release/client/src/bundles/vendor.js

Have you accidentally squashed the css change on top of an existing commit?

@emteknetnz
Copy link
Member Author

Rather than try and rebase this again, I've just redone in #1418

@emteknetnz emteknetnz closed this Dec 11, 2022
@GuySartorelli GuySartorelli deleted the pulls/1.12-release/chosen-overflow branch December 11, 2022 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants