Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Don't try to parse non-existent gridfield state #1386

Merged
merged 1 commit into from
Oct 18, 2022
Merged

FIX Don't try to parse non-existent gridfield state #1386

merged 1 commit into from
Oct 18, 2022

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli linked an issue Oct 18, 2022 that may be closed by this pull request
CMS 4.12: console error for any page with an elemental area (due to gridfield js) #1385
Closed
@GuySartorelli GuySartorelli mentioned this pull request Oct 18, 2022
Closed
michalkleiner
michalkleiner approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michalkleiner michalkleiner merged commit 603ef3e into silverstripe:1 Oct 18, 2022
@GuySartorelli GuySartorelli deleted the pulls/1/no-gridfield-state branch October 18, 2022 07:32
@michalkleiner
Copy link
Contributor

@GuySartorelli one test seems to fail after the merge — https://github.com/silverstripe/silverstripe-admin/actions/runs/3271324582 — do you think the timeout of 3x 200ms is perhaps too short? What else could be the reason for the failure apart from that?

@GuySartorelli
Copy link
Member Author

GuySartorelli commented Oct 18, 2022 •
edited
Loading

Intermittent failures for behat in ci is extremely common unfortunately - which is what this appears to be since it's only one of the behat jobs failing.
I've set the job to run again and expect it to pass.

Neither the underlying problem here nor the fix would actually affect behat runs since they don't seem to affect the actual behaviour. It was just a console warning.

@michalkleiner
Copy link
Contributor

Cool, thanks for the clarification 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMS 4.12: console error for any page with an elemental area (due to gridfield js)
2 participants
@GuySartorelli @michalkleiner