ENH Upgrade jquery to 1.12 #1353
Conversation
| const offset = activeTab.offset(); | ||
| padding = offset ? (offset.top - containerSouth.offset().top) : 0; |
There was a problem hiding this comment.
New tabs are now an empty object - there is no offset() function on them - so this just checks if there was an offset or not to avoid "that is undefined" error.
|
|
||
| // this._super(); | ||
| // return; | ||
| // } |
There was a problem hiding this comment.
This will need to be replaced with some more appropriate third-party solution - for now I removed it because jquery doesn't have a browser property anymore.
|
|
||
| /** | ||
| * Add focusin and focusout support to bind and live for browers other than IE. Designed to be usable in a delegated fashion (like $.live) | ||
| * Copyright (c) 2007 Jörn Zaefferer | ||
| */ | ||
| if ($.support.focusinBubbles === undefined) { | ||
| $.support.focusinBubbles = !!($.browser.msie); | ||
| } | ||
|
|
||
| if (!$.support.focusinBubbles && !$.event.special.focusin) { | ||
| // Emulate focusin and focusout by binding focus and blur in capturing mode | ||
| $.each({focus: 'focusin', blur: 'focusout'}, function(original, fix){ | ||
| $.event.special[fix] = { | ||
| setup: function(){ | ||
| if (!this.addEventListener) return false; | ||
| this.addEventListener(original, $.event.special[fix].handler, true); | ||
| }, | ||
| teardown: function(){ | ||
| if (!this.removeEventListener) return false; | ||
| this.removeEventListener(original, $.event.special[fix].handler, true); | ||
| }, | ||
| handler: function(e){ | ||
| arguments[0] = $.event.fix(e); | ||
| arguments[0].type = fix; | ||
| return $.event.handle.apply(this, arguments); | ||
| } | ||
| }; | ||
| }); | ||
| } |
There was a problem hiding this comment.
$.support is deprecated and $.browser doesn't exist - and anyway we aren't interested in supporting such old browsers so the easy fix to the errors this caused was to remove it.
| /** Taken from jQuery 1.5.2 for backwards compatibility */ | ||
| if ($.support.changeBubbles == undefined) { | ||
| $.support.changeBubbles = true; | ||
|
|
||
| var el = document.createElement("div"); | ||
| eventName = "onchange"; | ||
|
|
||
| if (el.attachEvent) { | ||
| var isSupported = (eventName in el); | ||
| if (!isSupported) { | ||
| el.setAttribute(eventName, "return;"); | ||
| isSupported = typeof el[eventName] === "function"; | ||
| } | ||
|
|
||
| $.support.changeBubbles = isSupported; | ||
| } | ||
| } |
There was a problem hiding this comment.
$.support is deprecated - and anyway we aren't interested in supporting such old browsers so the easy fix to the errors this caused was to remove it.
|
Closing in favor of #1375 |
A slightly different approach from #1352
There are comments in files changed about why some changes were made.
Parent issue