Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Test cases for testing GridField. Wrong alert issue #1320

Merged
merged 1 commit into from
Jul 12, 2022
Merged

MNT Test cases for testing GridField. Wrong alert issue #1320

merged 1 commit into from
Jul 12, 2022

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova commented Jul 5, 2022 •
edited
Loading

Description

New test cases for GridFIeld. Testing for wrong alert message after getting search result.

Parent issue

@sabina-talipova sabina-talipova mentioned this pull request Jul 5, 2022
Closed
5 tasks
@sabina-talipova sabina-talipova changed the base branch from 1 to 1.11 July 5, 2022 20:46
@GuySartorelli
Copy link
Member

Test case commits should use the MNT prefix - it's not something developers need to be aware of in the changelog.

@sabina-talipova sabina-talipova changed the title NEW Test cases for testing GridField. Wrong alert issue MNT Test cases for testing GridField. Wrong alert issue Jul 6, 2022
@GuySartorelli
Copy link
Member

GuySartorelli commented Jul 8, 2022 •
edited
Loading

Also add a quick test that you can navigate away after adding some search phrase (i.e. test that the "unsaved changes" alert doesn't appear)
Edit: I see now you have clicked on one of the items in the gridfield - but you're just checking if "Walmart" is visible, when it was already visible in the gridfield. So you'll see that whether you've managed to navigate away or not.

@sabina-talipova sabina-talipova force-pushed the pulls/1.11/gridfield-wrong-message-test branch from b8d6e5f to 916c41b Compare July 11, 2022 23:10
GuySartorelli
GuySartorelli requested changes Jul 12, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit message prefix from NEW to MNT and then I will merge.
You can use git commit --amend to change the message.

@sabina-talipova sabina-talipova force-pushed the pulls/1.11/gridfield-wrong-message-test branch from 916c41b to 8717e99 Compare July 12, 2022 03:20
GuySartorelli
GuySartorelli approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge on green

@GuySartorelli GuySartorelli merged commit f3dad18 into silverstripe:1.11 Jul 12, 2022
@GuySartorelli GuySartorelli deleted the pulls/1.11/gridfield-wrong-message-test branch July 12, 2022 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabina-talipova @GuySartorelli