Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG Add missing dependency to build pattern library #1291

Merged

Conversation

maxime-rainville
Copy link
Contributor

@maxime-rainville maxime-rainville commented Feb 22, 2022

The pattern library is throwing some errors for isPlainObject.isPlainObject is not a function. Adding the is-plain-object library to admin's dev dependencies fixes it.

image

Parent issue

Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MOG

@maxime-rainville maxime-rainville merged commit d466ec3 into silverstripe:1 Feb 22, 2022
@maxime-rainville maxime-rainville deleted the pulls/1/fix-pattern-lib branch February 22, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants