ENH Allow setting options for extra css/js in LeftAndMain. #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkleiner
approved these changes
Feb 14, 2022
GuySartorelli
force-pushed
the
enh/leftandmain-requirements-config
branch
from
3fe8661 to
96270d1
Compare
|
Might take a couple of tries to get the regex for the tests just right. I forgot to allow for the cache querystring. |
|
@michalkleiner Got it on the second try. All tests are now green. Thanks for approving this one so fast! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also made the js/css tests a little more robust to make sure the scripts and styles are actually in script/style tags, not just arbitrarily printed in the body.