ENH: Prefer dependency injection for GridFieldComponents. #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
enh/gridfieldcomponents-di
branch
from
202e855 to
54a619a
Compare
GridFieldComponents packaged with silverstripe/framework are injectable as of 4.11.0 Explicitly invoking the injector here instead of using `create()` allows backwards compatability with framework < 4.11.0 while ensuring dependency injection is still used from 4.11.0 onwards.
GuySartorelli
force-pushed
the
enh/gridfieldcomponents-di
branch
from
54a619a to
2f9a244
Compare
|
Once this has been approved I'll go through other repositories and check for |
michalkleiner
approved these changes
Feb 9, 2022
There was a problem hiding this comment.
Both approaches work for me, I'd prefer the ::create one but I'm not sure what's the appetite on forcing ^4.11 onto folks e.g. if someone uses admin in a different version to get newer stuff but wants to stay on older cms/framework. That would force them to alias those dependencies as well.
Will leave for @maxime-rainville or @emteknetnz to make the final call.
dhensby
approved these changes
Feb 10, 2022
This was referenced Feb 12, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GridFieldComponents packaged with silverstripe/framework will be injectable as of 4.11.0 (see silverstripe/silverstripe-framework#10204)Explicitly invoking the injector here instead of using
create()allows backwards compatibility with framework < 4.11.0 while ensuring dependency injection is still used from 4.11.0 onwards.If core team would prefer, I can instead use the
::create()static method which was added via theInjectabletrait - but that will also require updating the constraint for the framework dependency to^4.11.