FIX Treedropdown css #1166
FIX Treedropdown css #1166
Conversation
emteknetnz
force-pushed
the
pulls/1.7/treedropdown-css
branch
2 times, most recently
from
203211e to
f791ef2
Compare
| .is-open>.Select-control, | ||
| .Select-menu-outer { | ||
| .Select-arrow-zone { | ||
| vertical-align: initial; |
There was a problem hiding this comment.
This seems to actually just move the arrow up by about 1 pixel instead of vertically centering it.
There was a problem hiding this comment.
I'm not sure about this? See screenshot below
There was a problem hiding this comment.
This is what it looks like for me.
Left is the current look.
Right is with vertical-align: initial; applied.
Looks to me like we don't need to do anything here.
There was a problem hiding this comment.
Have removed the vertical align
|
a) What's wrong with the text colour? I'm not sure what you're referring to? b) Re the arrow alignment, testing in chrome, it seems fine?: Before: After: |
emteknetnz
force-pushed
the
pulls/1.7/treedropdown-css
branch
from
f791ef2 to
70d3342
Compare
| .is-open>.Select-control, | ||
| .Select-menu-outer { | ||
| .Select-arrow-zone { | ||
| vertical-align: initial; |
There was a problem hiding this comment.
This is what it looks like for me.
Left is the current look.
Right is with vertical-align: initial; applied.
Looks to me like we don't need to do anything here.
| .Select-control { | ||
| border-color: $gray-200; | ||
| box-shadow: none; | ||
| } | ||
|
|
||
| .Select.is-focused:not(.is-open) > .Select-control, | ||
| .is-open > .Select-control { | ||
| border-color: $brand-primary; | ||
| } |
There was a problem hiding this comment.
Need to move box shadow to .Select.is-focused:not(.is-open) > .Select-control.
There was a problem hiding this comment.
Have added box-shadow: none so that the box shadows doesn't show
The box shadows comes from react-select - the DSM linked in the parent issue has no box-shadows so this seems correct https://projects.invisionapp.com/dsm/silver-stripe/silver-stripe/asset/components/5acd939108f7520011a65e5c
emteknetnz
force-pushed
the
pulls/1.7/treedropdown-css
branch
from
70d3342 to
13ad24b
Compare
emteknetnz
force-pushed
the
pulls/1.7/treedropdown-css
branch
from
13ad24b to
771cb5f
Compare
Fixes #853