Make security admin more easily extensible

- fix error if import button is missing - fix unhandled match case if model class is not member or group
silverstripe · Aug 14, 2023 · 6ef5b9b · 6ef5b9b
1 parent 5b09805
commit 6ef5b9b
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/code/SecurityAdmin.php b/code/SecurityAdmin.php
@@ -128,11 +128,16 @@ protected function getGridFieldConfig(): GridFieldConfig
         }
         /** @var GridFieldImportButton $importButton */
         $importButton = $config->getComponentByType(GridFieldImportButton::class);
-        $modalTitle = match ($this->modelClass) {
-            Member::class => _t(__CLASS__ . '.IMPORTUSERS', 'Import users'),
-            Group::class => _t(__CLASS__ . '.IMPORTGROUPS', 'Import groups'),
-        };
-        $importButton->setModalTitle($modalTitle);
+        if ($importButton) {
+            $modalTitle = match ($this->modelClass) {
+                Member::class => _t(__CLASS__ . '.IMPORTUSERS', 'Import users'),
+                Group::class => _t(__CLASS__ . '.IMPORTGROUPS', 'Import groups'),
+                default => null,
+            };
+            if ($modalTitle !== null) {
+                $importButton->setModalTitle($modalTitle);
+            }
+        }
         return $config;
     }