Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP Use v3 of silverstripe-composer-update-checker #26

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Apr 20, 2022

Issue silverstripe/silverstripe-framework#10250

Relates to bringyourownideas/silverstripe-composer-update-checker#62

Travis build is failing because we need to tag a new major of silverstripe-composer-update-checker to make things installable

@emteknetnz emteknetnz force-pushed the pulls/1/update-checker branch from 5d022b8 to b841a0c Compare April 20, 2022 01:02
@emteknetnz emteknetnz changed the title Use v3 of silverstripe-composer-update-checker DEP Use v3 of silverstripe-composer-update-checker Apr 20, 2022
@emteknetnz emteknetnz marked this pull request as ready for review April 20, 2022 05:07
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but will wait for the stable branch and for tests to be re-run before merging.

@GuySartorelli GuySartorelli merged commit e5eeeb9 into silverstripe:1 Apr 26, 2022
@GuySartorelli GuySartorelli deleted the pulls/1/update-checker branch April 26, 2022 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants