Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Don't accidentally skip framework tests #45

Merged
merged 1 commit into from
Aug 6, 2023
Merged

MNT Don't accidentally skip framework tests #45

merged 1 commit into from
Aug 6, 2023

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Aug 4, 2023 •
edited
Loading

If we added a new directory under framework/tests/php we would likely not remember to add it to this list - so lets just include everything that isn't ORM instead.

Issue

@GuySartorelli GuySartorelli mentioned this pull request Aug 4, 2023
Closed
4 tasks
@GuySartorelli
Copy link
Member Author

MFA CI failure is unrelated

@emteknetnz emteknetnz merged commit 9b5edc6 into silverstripe:4.13 Aug 6, 2023
22 of 23 checks passed
@emteknetnz emteknetnz deleted the pulls/4.13/split-orm-tests branch August 6, 2023 23:58
@emteknetnz emteknetnz mentioned this pull request Sep 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz