DEP PHP Support in CMS5 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
sabina-talipova
force-pushed
the
pulls/5/upgrade-cms5
branch
from
754f5ab to
cd343c3
Compare
|
Requires silverstripe/silverstripe-frameworktest#135 to be merged first |
emteknetnz
force-pushed
the
pulls/5/upgrade-cms5
branch
from
e1b65e7 to
cd343c3
Compare
emteknetnz
force-pushed
the
pulls/5/upgrade-cms5
branch
2 times, most recently
from
9028879 to
7e10c8d
Compare
sabina-talipova
force-pushed
the
pulls/5/upgrade-cms5
branch
2 times, most recently
from
cd343c3 to
b9243b9
Compare
emteknetnz
force-pushed
the
pulls/5/upgrade-cms5
branch
2 times, most recently
from
6e6a5a1 to
8c6264d
Compare
|
We'll deal with unit test failures in various modules in a follow broken builds card. For now the main this was just get recipe-kitchen-sink installable |
Comment on lines
+31
to
+35
| # TODO: renable prefer-lowest build once CMS 5 beta is out | ||
| # - php: 8.1 | ||
| # composer_args: --prefer-lowest | ||
| # phpunit: true | ||
| # phpunit_suite: recipe-cms |
There was a problem hiding this comment.
I've added this to silverstripe/gha-generate-matrix#41
emteknetnz
force-pushed
the
pulls/5/upgrade-cms5
branch
from
8c6264d to
43f0fcd
Compare
GuySartorelli
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue