FIX Make UTF-MB4 collation / charset default opt-in #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was originally intended as an opt-in change in Recipe 4.7.0, but was making its way into projects during upgrades due to its placement in a separate config file.
This was referenced Jan 12, 2021
Merged
|
Good stuff! We've done a previous opt-in change in installer instead of an existing YAML config in recipe-core, so it's a bit inconsistent - but I prefer it in recipe-core, since many people won't use the installer (and we shouldn't encourage it either). |
This comment has been minimized.
This comment has been minimized.
kinglozzer
approved these changes
Jan 12, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally intended as an opt-in change in Recipe 4.7.0, but was making its way into projects during upgrades due to its placement in a separate config file.
Related: silverstripe/silverstripe-framework#9811