Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Remove old logic to default UTF8 DB setting to 4 bytes #102

Conversation

maxime-rainville
Copy link
Contributor

@maxime-rainville maxime-rainville commented Oct 19, 2024

Description

Remove pointless setting in default project config to update UTF8 setting in DB

Issues

Related PR

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@maxime-rainville
Copy link
Contributor Author

Build is failing, but it's not clear to me it's got anything to do with this PR.

I've triggered a manual run for the 6 branch and will check later: https://github.com/silverstripe/recipe-core/actions/runs/11417090805

@GuySartorelli
Copy link
Member

Some of the failures are unrelated for sure. Some might just be because we're expecting these values for the connection. Rerunning now that the framework PR has been merged.

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now only failing in the same places as the 6 branch of the repo itself.
Change looks good. Thanks!

@GuySartorelli GuySartorelli merged commit bade7f2 into silverstripe:6 Oct 20, 2024
4 of 6 checks passed
@maxime-rainville maxime-rainville deleted the pulls/6/remove-legacy-charset-setting branch October 21, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants