Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API phpunit 9 support #19

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz force-pushed the pulls/2/sapphire-test-nine branch from 12e1245 to 9d52970 Compare October 19, 2021 01:38
@emteknetnz emteknetnz force-pushed the pulls/2/sapphire-test-nine branch from 9d52970 to 53ac14d Compare October 27, 2021 22:48
@emteknetnz emteknetnz marked this pull request as ready for review November 3, 2021 22:15
@emteknetnz emteknetnz force-pushed the pulls/2/sapphire-test-nine branch from 53ac14d to eba2137 Compare November 4, 2021 20:47
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... Restarted the build

@emteknetnz emteknetnz force-pushed the pulls/2/sapphire-test-nine branch from eba2137 to 24c2aa1 Compare November 9, 2021 04:41
@emteknetnz
Copy link
Member Author

@maxime-rainville broken unit test requires tagging a new minor of silverstripe/gridfiedextensions which has framework ^4.10 as a requirement, so we should merge this with a broken unit test

@maxime-rainville maxime-rainville merged commit d23a8f4 into silverstripe:2 Nov 10, 2021
@maxime-rainville maxime-rainville deleted the pulls/2/sapphire-test-nine branch November 10, 2021 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants