-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEP Use carets instead of dev requirements and use phpunit 9 #3
DEP Use carets instead of dev requirements and use phpunit 9 #3
Conversation
74d226a
to
9b70a55
Compare
^ broken travis test is phpunit9 related - fix is to tag 2.9.0 (new minor) of cwp-core - https://github.com/silverstripe/cwp-core/pull/101/files @maxime-rainville this might be a bit weird, particularly as that requires framework ^4.10 which is unreleased - may make sense to just merge this with broken unit test? |
@emteknetnz Do you want to do a new |
@maxime-rainville tagged cwp-core 2.9.0 and rerunning the build on this |
9b70a55
to
6110f07
Compare
Unit test requires silverstripe/admin 4.10/4.x-dev due to phpunit 9 Requirement for admin would need to be updated in to ^4.10 in However I tagged cwp-core 2.9.0 just the other day, probably a little excessive tagged 2.10 days later - might make sense to just remove the tag and retag - though this would require us deleting the tag in packagist as well which I don't have enough permissions to do https://packagist.org/packages/cwp/cwp-core#2.9.0 Other option is just tag 2.9.1, though I'm not sure if that's semver correct |
I'm fine tagging 2.9.1. As a general rule, we should never undo a tag. |
Cool - PR silverstripe/cwp-core#104 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and build are green.
Issue https://github.com/silverstripeltd/product-issues/issues/497
Now that CWP won't be getting regular releases via cow, it probably makes sense to change this to carets to support adhoc releases