Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP Dependencies for CMS 6 #33

Conversation

emteknetnz
Copy link
Member

"silverstripe/tagfield": "3.x-dev",
"silverstripe/taxonomy": "3.x-dev"
"silverstripe/recipe-cms": "6.x-dev",
"silverstripe/documentconverter": "4.x-dev",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no way we're making document converter CMS 6 compatible, so remove that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll create a CMS 6 branch for now and look at support at a later date

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's ridiculous but sure.

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Failures are expected at this stage so ignoring CI.

@GuySartorelli GuySartorelli merged commit 50c5891 into silverstripe:3 Feb 20, 2024
8 checks passed
@GuySartorelli GuySartorelli deleted the pulls/3/module-standardiser-1708320634 branch February 20, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants