Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP PHP Support in CMS5 #24

Merged
merged 1 commit into from
Jan 11, 2023
Merged

DEP PHP Support in CMS5 #24

merged 1 commit into from
Jan 11, 2023

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova mentioned this pull request Dec 12, 2022
Closed
3 tasks
@sabina-talipova sabina-talipova force-pushed the pulls/2/upgrade-cms5 branch 4 times, most recently from 61ac428 to 4cbb13a Compare December 19, 2022 21:09
@sabina-talipova
Copy link
Contributor Author

Requires silverstripe/silverstripe-iframe#63

maxime-rainville
maxime-rainville approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxime-rainville maxime-rainville merged commit d625008 into silverstripe:2 Jan 11, 2023
@maxime-rainville maxime-rainville deleted the pulls/2/upgrade-cms5 branch January 11, 2023 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-rainville maxime-rainville maxime-rainville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabina-talipova @maxime-rainville