Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Ensure yarn scripts exist before running them #3

Merged
merged 1 commit into from
Jul 7, 2022
Merged

FIX Ensure yarn scripts exist before running them #3

merged 1 commit into from
Jul 7, 2022

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Jul 7, 2022 •
edited
Loading

Issue silverstripe/gha-ci#11

Some package.json files do not have yarn scripts build/test/lint defined. If not defined, then skip them.

Example

Running yarn test
yarn run v1.22.19
error Command "test" not found.

https://github.com/creative-commoners/cwp-starter-theme/runs/7242059614?check_suite_focus=true#step:12:347

@emteknetnz emteknetnz mentioned this pull request Jul 7, 2022
Closed
40 tasks
@GuySartorelli GuySartorelli merged commit afdb0a9 into silverstripe:1.0 Jul 7, 2022
@GuySartorelli GuySartorelli deleted the pulls/1.0/yarn branch July 7, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli