Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pulls/1.12/fix it properly this time #79

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Pulls/1.12/fix it properly this time #79

merged 1 commit into from
Jan 29, 2024

Conversation

GuySartorelli
Copy link
Member

I screwed up the logic for setting needs_full_setup again - this time I've added a comment to make it really clear what the logic is meant to be.

  • If there is an installer version, it needs full setup.
  • If there is no installer version, but this repo is in the NO_INSTALLER_LOCKSTEPPED_REPOS const, it needs full setup.
  • Everything else doesn't need it.

Issues

@GuySartorelli GuySartorelli changed the base branch from 1 to 1.12 January 29, 2024 01:17
@GuySartorelli GuySartorelli mentioned this pull request Jan 29, 2024
Closed
@emteknetnz emteknetnz merged commit d2fb178 into silverstripe:1.12 Jan 29, 2024
4 checks passed
@emteknetnz emteknetnz deleted the pulls/1.12/fix-it-properly-this-time branch January 29, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz