FIX Update getInstallerVersion #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 tasks
emteknetnz
force-pushed
the
pulls/1.1/branch-on-push
branch
7 times, most recently
from
4936d41 to
54cc5af
Compare
|
Can you please add some details to the PR description about what is actually being fixed or updated with this PR? |
|
Updated |
GuySartorelli
requested changes
Jun 30, 2022
| } | ||
| // use the latest minor version of installer |
There was a problem hiding this comment.
The only situation where this isn't ideal is prefer-lowest won't actually be testing the lowest version of framework according to the constraint in composer.json.... but we can probably live with that.
emteknetnz
force-pushed
the
pulls/1.1/branch-on-push
branch
2 times, most recently
from
0f8ca86 to
1f056fc
Compare
|
@GuySartorelli have made requested changes |
emteknetnz
force-pushed
the
pulls/1.1/branch-on-push
branch
from
1f056fc to
9ce493f
Compare
GuySartorelli
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/gha-ci#11
Updating the logic in
getInstallerVersion()so that the correct version is returnedExample failure
PHP Warning: Undefined array key "4.10/module-standards" in /home/runner/work/_actions/silverstripe/gha-generate-matrix/v1/job_creator.php on line 39Also a slight refactor to allow adding unit tests for the yaml parsing