Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Update unit tests for PHP 8.4 #113

Merged
merged 1 commit into from
Nov 28, 2024
Merged

MNT Update unit tests for PHP 8.4 #113

merged 1 commit into from
Nov 28, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Nov 28, 2024 •
edited
Loading

@emteknetnz emteknetnz mentioned this pull request Nov 28, 2024
Closed
2 tasks
@emteknetnz emteknetnz changed the base branch from 1 to 1.17 November 28, 2024 02:00
@emteknetnz emteknetnz changed the title ENH PHP 8.4 job for CMS 6 MNT Update unit tests for PHP 8.4 Nov 28, 2024
GuySartorelli
GuySartorelli approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 9057362 into silverstripe:1.17 Nov 28, 2024
2 checks passed
@GuySartorelli GuySartorelli deleted the pulls/1/php84 branch November 28, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli