Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Exclude recipe-plugin from requiring installer #11

Merged

Conversation

emteknetnz
Copy link
Member

Issue silverstripe/gha-ci#11

Fixes

PHP Fatal error:  Uncaught Error: Class 'Page' not found in /home/runner/work/recipe-plugin/recipe-plugin/vendor/silverstripe/errorpage/src/ErrorPage.php:39

https://github.com/creative-commoners/recipe-plugin/runs/7191506616?check_suite_focus=true

@GuySartorelli
Copy link
Member

recipe-plugin has no tests - what does it need ci for?

@emteknetnz
Copy link
Member Author

emteknetnz commented Jul 6, 2022

running phpcs on /src

@GuySartorelli GuySartorelli merged commit c6dca88 into silverstripe:1.1 Jul 6, 2022
@GuySartorelli GuySartorelli deleted the pulls/1.1/recipe-plugin branch July 6, 2022 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants