FIX Use max of PHP 8.0 for x.10 recipes #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 tasks
GuySartorelli
requested changes
Jul 4, 2022
emteknetnz
force-pushed
the
pulls/1.1/framework-410
branch
2 times, most recently
from
766884b to
d9a71d7
Compare
emteknetnz
force-pushed
the
pulls/1.1/framework-410
branch
from
d9a71d7 to
7317bd3
Compare
GuySartorelli
approved these changes
Jul 5, 2022
Comment on lines
+94
to
+96
| if (preg_match('#^[1-9]$#', $branch)) { | ||
| $branchMajor = $branch; | ||
| } elseif (preg_match('#^([1-9])\.[0-9]+$#', $branch, $matches)) { |
There was a problem hiding this comment.
These won't work for major 10.x, but we're a long way off that so I'm not concerned about it. Just pointing it out as a matter of course.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/gha-ci#11
Ensure that x.10 recipes have a maximum PHP version on 8.0 - this is to prevent deprecation warnings when running PHP 8.1
Also back filled in some general unit tests