FIX Don't set up database etc if not needed #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 28, 2024
emteknetnz
requested changes
Jan 28, 2024
.github/workflows/ci.yml
Outdated
|
|
||
| if [[ NEEDS_FULL_SETUP == "false" ]]; then | ||
| echo "skipping .env, database, and other full site setup steps" | ||
| exit 0 |
There was a problem hiding this comment.
Instead of existing which may mess up the rest of the job, just move the block of code inside the conditional
GuySartorelli
force-pushed
the
pulls/1.5/no-db-unless-needed
branch
from
18f7589 to
ddfd055
Compare
emteknetnz
requested changes
Jan 28, 2024
.github/workflows/ci.yml
Outdated
| # composer install does actually remove the artifact directory | ||
| mkdir artifacts | ||
|
|
||
| if [[ NEEDS_FULL_SETUP == "false" ]]; then |
There was a problem hiding this comment.
Suggested change
| if [[ NEEDS_FULL_SETUP == "false" ]]; then | |
| if [[ $NEEDS_FULL_SETUP == 'false' ]]; then |
Need a $ for the variable :-)
Using single quotes just to copy style above where a conditional check was done if [[ $SUCCESSFULLY_REQUIRED == 'false' ]]; then
There was a problem hiding this comment.
The single/double quotes isn't consistent everywhere in this file (I copied double quotes from somewhere in here too) but I have no issues with that change.
Done.
GuySartorelli
force-pushed
the
pulls/1.5/no-db-unless-needed
branch
from
ddfd055 to
a279c16
Compare
emteknetnz
approved these changes
Jan 29, 2024
|
@GuySartorelli Once this has auto-tagged could you manually re-trigger a recipe + a regular module + something without installer just to double check things still work as expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires silverstripe/gha-generate-matrix#77 to be merged and tagged first.
Issue