DOC Update readme with phpcoverage_force_off input #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -60,7 +60,8 @@ jobs: | |||
| # github.ref_name - The branch or tag name that triggered the workflow run - same as github.ref though without the leading refs/[heads|tags]/ | |||
| echo "github.ref_name: $GITHUB_REF_NAME" | |||
| # gitbub.repository - The owner and repository name. For example, Codertocat/Hello-World | |||
| echo "$github.repository: $GITHUB_REPOSITORY" | |||
| # On forked repos, this will show <account_of_fork>/<repo> | |||
There was a problem hiding this comment.
Does this mean for PRs as well? If not, what situations will this be run from a forked repo?
There was a problem hiding this comment.
I'm not actually sure, once we've merged the framework ci.yml we can do a PR to it and see what comes up in context. I'm going to assume it'll be silverstripe, if not and it shows the fork, meaning the action is running on the fork and not the base, it's not the end of the world, it just means that codecov won't run on the pull-request, though it will run post merge on the 4 / 4.11 branch. We don't block PR's based on codecov declining, it's more of an ongoing metric
GuySartorelli
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #11