MNT Output more info for debugging failures #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/ci.yml
Outdated
| cat << EOF > .env | ||
| SS_DATABASE_CLASS="SQLite3Database" | ||
| SS_DATABASE_USERNAME="root" | ||
| SS_DATABASE_PASSWORD="" | ||
| SS_SQLITE_DATABASE_PATH=":memory:" | ||
| EOF | ||
| elif [[ "${{ matrix.db }}" =~ mariadb ]]; then | ||
| echo "mariadb version": | ||
| mysql --version |
There was a problem hiding this comment.
I think it should be mariadb --version, isn't it?
There was a problem hiding this comment.
Oops not correct, but not for the reason you're thinking. The mysql cli will work fine here.
I need to tell it which port to look at (same for the mysql databases) so it gives us the correct version.
GuySartorelli
force-pushed
the
pulls/1.6/more-debug-output
branch
from
98bebe3 to
65fed72
Compare
sabina-talipova
approved these changes
Feb 21, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a few things that could be causing the mariadb failure, such as missing PHP mods, misconfigured ini, breaking changes in mariadb if that updated, etc.
This PR gives a little more info about what's installed in CI to help rule out possibilities.
Issue