MNT Use GitHub Actions CI

.github/workflows/ci.yml

@@ -0,0 +1,16 @@
+name: CI
+
+on:
+  push:
+  pull_request:
+  workflow_dispatch:
+  # Every Monday at 2:00pm UTC
+  schedule:
+    - cron: '0 14 * * 1'
+
+jobs:
+  ci:
+    name: CI
+    # Only run cron on the silverstripe account
+    if: (github.event_name == 'schedule' && startsWith(github.repository, 'silverstripe/')) || (github.event_name != 'schedule')
+    uses: silverstripe/gha-ci/.github/workflows/ci.yml@v1

.github/workflows/keepalive.yml

@@ -0,0 +1,17 @@
+name: Keepalive
+
+on:
+  workflow_dispatch:
+  # The 4th of every month at 10:50am UTC
+  schedule:
+    - cron: '50 10 4 * *'
+
+jobs:
+  keepalive:
+    name: Keepalive
+    # Only run cron on the silverstripe account
+    if: (github.event_name == 'schedule' && startsWith(github.repository, 'silverstripe/')) || (github.event_name != 'schedule')
+    runs-on: ubuntu-latest
+    steps:
+      - name: Keepalive
+        uses: silverstripe/gha-keepalive@v1

composer.json

@@ -7,7 +7,7 @@
     "jeremeamia/superclosure": "^2.0"
   },
   "require-dev": {
-    "phpunit/phpunit": "^4.8.36|^5.7.27"
+    "phpunit/phpunit": "^9.5"
   },
   "autoload": {
     "psr-4": {

phpcs.xml.dist

@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<ruleset name="SilverStripe">
+    <description>CodeSniffer ruleset for SilverStripe coding conventions.</description>
+
+    <file>src</file>
+    <file>tests</file>
+
+    <!-- base rules are PSR-2 -->
+    <rule ref="PSR2" >
+        <!-- Current exclusions -->
+        <exclude name="PSR1.Files.SideEffects.FoundWithSymbols" />
+        <exclude name="PSR1.Methods.CamelCapsMethodName.NotCamelCaps" />
+    </rule>
+</ruleset>

src/Manager/ProcessManager.php

@@ -65,7 +65,7 @@ class ProcessManager implements Manager
 
     /**
      * Get a list of the waiting tasks.
-     * 
+     *
      * @return array
      */
     public function getWaiting()
@@ -75,7 +75,7 @@ public function getWaiting()
 
     /**
      * Get a list of the running tasks.
-     * 
+     *
      * @return array
      */
     public function getRunning()

src/Rules/InMemoryRules.php

@@ -69,7 +69,12 @@ public function canRunTask(Task $task, Profile $profile)
                 continue;
             }
 
-            if (($rule->getHandler() === null || $rule->getHandler() === $task->getHandler()) && ($this->hasTooManyProcessesRunning($rule, $profile) || $this->hasTooManySiblingProcessesRunning($rule, $profile))) {
+            if (($rule->getHandler() === null || $rule->getHandler() === $task->getHandler()) &&
+                (
+                    $this->hasTooManyProcessesRunning($rule, $profile) ||
+                    $this->hasTooManySiblingProcessesRunning($rule, $profile)
+                )
+            ) {
                 return false;
             }
         }
@@ -128,7 +133,8 @@ private function withinConstraints(Rule $rule, Profile $profile)
     private function withinProcessorConstraints(Rule $rule, Profile $profile)
     {
         if ($rule->getMinimumProcessorUsage() !== null && $rule->getMaximumProcessorUsage() !== null) {
-            return $profile->getProcessorLoad() >= $rule->getMinimumProcessorUsage() && $profile->getProcessorLoad() <= $rule->getMaximumProcessorUsage();
+            return $profile->getProcessorLoad() >= $rule->getMinimumProcessorUsage() &&
+                $profile->getProcessorLoad() <= $rule->getMaximumProcessorUsage();
         }
 
         return false;
@@ -145,7 +151,8 @@ private function withinProcessorConstraints(Rule $rule, Profile $profile)
     private function withinMemoryConstraints(Rule $rule, Profile $profile)
     {
         if ($rule->getMinimumMemoryUsage() !== null && $rule->getMaximumMemoryUsage() !== null) {
-            return $profile->getMemoryLoad() >= $rule->getMinimumMemoryUsage() && $profile->getMemoryLoad() <= $rule->getMaximumMemoryUsage();
+            return $profile->getMemoryLoad() >= $rule->getMinimumMemoryUsage() &&
+                $profile->getMemoryLoad() <= $rule->getMaximumMemoryUsage();
         }
 
         return false;
@@ -161,7 +168,8 @@ private function withinMemoryConstraints(Rule $rule, Profile $profile)
      */
     private function hasTooManySiblingProcessesRunning(Rule $rule, Profile $profile)
     {
-        return $this->withinSiblingConstraints($rule, $profile) && count($profile->getSiblingProcesses()) >= $rule->getProcesses();
+        return $this->withinSiblingConstraints($rule, $profile) &&
+            count($profile->getSiblingProcesses()) >= $rule->getProcesses();
     }
 
     /**
@@ -174,7 +182,8 @@ private function hasTooManySiblingProcessesRunning(Rule $rule, Profile $profile)
      */
     private function withinSiblingConstraints(Rule $rule, Profile $profile)
     {
-        return $this->withinSiblingProcessorConstraints($rule, $profile) || $this->withinSiblingMemoryConstraints($rule, $profile);
+        return $this->withinSiblingProcessorConstraints($rule, $profile) ||
+            $this->withinSiblingMemoryConstraints($rule, $profile);
     }
 
     /**
@@ -189,7 +198,8 @@ private function withinSiblingConstraints(Rule $rule, Profile $profile)
     private function withinSiblingProcessorConstraints(Rule $rule, Profile $profile)
     {
         if ($rule->getMinimumSiblingProcessorUsage() !== null && $rule->getMaximumSiblingProcessorUsage() !== null) {
-            return $profile->getSiblingProcessorLoad() >= $rule->getMinimumSiblingProcessorUsage() && $profile->getSiblingProcessorLoad() <= $rule->getMaximumSiblingProcessorUsage();
+            return $profile->getSiblingProcessorLoad() >= $rule->getMinimumSiblingProcessorUsage() &&
+                $profile->getSiblingProcessorLoad() <= $rule->getMaximumSiblingProcessorUsage();
         }
 
         return false;
@@ -206,7 +216,8 @@ private function withinSiblingProcessorConstraints(Rule $rule, Profile $profile)
     private function withinSiblingMemoryConstraints(Rule $rule, Profile $profile)
     {
         if ($rule->getMinimumSiblingMemoryUsage() !== null && $rule->getMaximumSiblingMemoryUsage() !== null) {
-            return $profile->getSiblingMemoryLoad() >= $rule->getMinimumSiblingMemoryUsage() && $profile->getSiblingMemoryLoad() <= $rule->getMaximumSiblingMemoryUsage();
+            return $profile->getSiblingMemoryLoad() >= $rule->getMinimumSiblingMemoryUsage() &&
+                $profile->getSiblingMemoryLoad() <= $rule->getMaximumSiblingMemoryUsage();
         }
 
         return false;

tests/Handler/CallbackHandlerTest.php

@@ -19,7 +19,7 @@ class CallbackHandlerTest extends Test
     /**
      * @inheritdoc
      */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
 

tests/Manager/GroupProcessManagerTest.php

@@ -20,7 +20,7 @@ class GroupProcessManagerTest extends Test
     /**
      * @inheritdoc
      */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
 

tests/Manager/ProcessManagerTest.php

@@ -22,7 +22,7 @@ class ProcessManagerTest extends Test
     /**
      * @inheritdoc
      */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
 

tests/Manager/SynchronousManagerTest.php

@@ -19,7 +19,7 @@ class SynchronousManagerTest extends Test
     /**
      * @inheritdoc
      */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
 

tests/Profile/InMemoryProfileTest.php

@@ -19,7 +19,7 @@ class InMemoryProfileTest extends Test
     /**
      * @inheritdoc
      */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
 

tests/Rule/InMemoryRuleTest.php

@@ -18,7 +18,7 @@ class InMemoryRuleTest extends Test
     /**
      * @inheritdoc
      */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
 

tests/Rules/InMemoryRulesTest.php

@@ -21,7 +21,7 @@ class InMemoryRulesTest extends Test
     /**
      * @inheritdoc
      */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
 

tests/Shell/BashShellTest.php

@@ -18,7 +18,7 @@ class BashShellTest extends Test
     /**
      * @inheritdoc
      */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
 

tests/Task/CallbackTaskTest.php

@@ -23,7 +23,7 @@ class CallbackTaskTest extends Test
     /**
      * @inheritdoc
      */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
 

tests/Task/ProcessCallbackTaskTest.php

@@ -18,7 +18,7 @@ class ProcessCallbackTaskTest extends Test
     /**
      * @inheritdoc
      */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
 

tests/Test.php

@@ -2,9 +2,9 @@
 
 namespace AsyncPHP\Doorman\Tests;
 
-use PHPUnit_Framework_TestCase;
+use PHPUnit\Framework\TestCase;
 
-abstract class Test extends PHPUnit_Framework_TestCase
+abstract class Test extends TestCase
 {
     /**
      * Safely deletes a file.