DOC Document SiteTree form field scaffolding #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
Aug 12, 2024
| scaffold_cmsfields_settings: | ||
| restrictRelations: | ||
| - 'EmailRecipients' | ||
| ``` |
There was a problem hiding this comment.
This yaml snippet is pretty long - if you want I can put it inside a collapsed <details> block.
There was a problem hiding this comment.
Yeah collapsible would be good.
GuySartorelli
force-pushed
the
pulls/6/scaffolded-sitetree
branch
from
36c0c70
to
4ceb0b2
Compare
emteknetnz
requested changes
Aug 13, 2024
| scaffold_cmsfields_settings: | ||
| restrictRelations: | ||
| - 'EmailRecipients' | ||
| ``` |
There was a problem hiding this comment.
Yeah collapsible would be good.
en/08_Changelogs/6.0.0.md
Outdated
|
|
||
| [`SiteTree::getCMSFields()`](api:SilverStripe\CMS\Model\SiteTree::getCMSFields()) used to create its form fields from scratch, without calling `parent::getCMSFields()`. This meant that all subclasses of `SiteTree` (i.e. all of your `Page` classes) had to explicitly define all form fields. | ||
|
|
||
| `SiteTree::getCMSFields()` now uses same form field scaffolding that all other `DataObject` subclasses use. |
There was a problem hiding this comment.
Suggested change
| `SiteTree::getCMSFields()` now uses same form field scaffolding that all other `DataObject` subclasses use. | |
| `SiteTree::getCMSFields()` now uses the same form field scaffolding that all other `DataObject` subclasses use. |
Also updates best practices around scaffolding form fields.
GuySartorelli
force-pushed
the
pulls/6/scaffolded-sitetree
branch
from
4ceb0b2
to
f019154
Compare
emteknetnz
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates best practices around scaffolding form fields.
Issue