Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Document added generic types #438

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Jan 14, 2024

Description

Documents the fact that we're adding generic typehints, what the intention is, and changes that developers can make to take full advantage of the new typehints.

Has two commits - the first is a small change to linting rules to allow use statements that are only used in annotations. This is required for the @extends Extension<SiteConfig> example.

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no TODO comments, unrelated rewording/restructuring, or arbitrary changes)
    • Small amounts of additional changes are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • The changes follow our writing style guide
  • Code examples follow our coding conventions
  • CI is green

@GuySartorelli GuySartorelli changed the title Pulls/5/add generics DOC Document added generic types Jan 14, 2024
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention the code that was deprecated in the framework PR

@GuySartorelli
Copy link
Member Author

Done (and rebased)

@emteknetnz emteknetnz merged commit af1a7a2 into silverstripe:5 Jan 23, 2024
3 checks passed
@emteknetnz emteknetnz deleted the pulls/5/add-generics branch January 23, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants