Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Ignore lint failure we can't fix #131

Merged

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Aug 12, 2024

Fixes https://github.com/silverstripe/cwp-agencyextensions/actions/runs/10269334178/job/28414559994

First argument passed to _t() must have exactly one period.

We should avoid changing i18n keys outside of a major release, and this module is on the chopping block to lose its supported status in CMS 6 so no sense changing it there either.

Issue

@emteknetnz emteknetnz merged commit 718b7c5 into silverstripe:3.2 Aug 13, 2024
10 checks passed
@emteknetnz emteknetnz deleted the pulls/3.2/lint-failure branch August 13, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants