Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processed Updates Service minor performance improvement #75

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

chrispenny
Copy link
Member

@chrispenny chrispenny commented Oct 1, 2023

Store the ProcessedUpdateDtos with a key so that they can be directly accessed - rather than looping through them all and checking the ClassName/ID individually.

The performance improvement is honestly negligible, but this is probably closer to "best practice".

@chrispenny chrispenny force-pushed the feature/processed-updates-perf-improvement branch from eb19d8b to 1e8e0fd Compare October 1, 2023 20:10
@chrispenny chrispenny force-pushed the feature/processed-updates-perf-improvement branch from ab601b1 to 0f7dc38 Compare October 2, 2023 19:42
@chrispenny chrispenny force-pushed the feature/processed-updates-perf-improvement branch from 0f7dc38 to 63e18f1 Compare October 2, 2023 19:44
@chrispenny chrispenny merged commit d28ce60 into main Oct 2, 2023
20 checks passed
@chrispenny chrispenny deleted the feature/processed-updates-perf-improvement branch October 2, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant