Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for base and extended classes #36

Merged
merged 2 commits into from
Jan 20, 2022

Conversation

chrispenny
Copy link
Member

@chrispenny chrispenny commented Dec 21, 2021

Closes #35

Details on the bug can be found above.

The goal is for us to find any Edge for the instance ClassName or any ancestor that the instance might have.

Regarding the $disallowList in getEdgesFrom(). Technically you can have a relationship to DataObject if you're using a polymorphic relationship. We haven't explicitly added support for polymorphic relationships though, so I opted to leave this our for now. I'll raise an improvement story for later.

@chrispenny chrispenny force-pushed the bugfix/extended-object-support branch from 06109ae to a9274fc Compare December 21, 2021 21:47
@chrispenny chrispenny merged commit 26ed21b into main Jan 20, 2022
@chrispenny chrispenny deleted the bugfix/extended-object-support branch January 20, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Keys not clearing for extended DataObjects
1 participant