Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider escaping newline/paragraph separators in JSONP responses #36

Closed
onebytegone opened this issue Mar 21, 2019 · 2 comments
Closed

Consider escaping newline/paragraph separators in JSONP responses #36

onebytegone opened this issue Mar 21, 2019 · 2 comments
Assignees
@onebytegone

Comments

@onebytegone
Copy link
Contributor

To fix expressjs/express#1132, express started escaping \u2028 and \u2029 as these were valid in JSON, but not JS (was changed in this proposal). Should lambda-express also perform a similar escaping?

See also:
@jthomerson
Copy link
Member

Makes sense to me. Good catch.

onebytegone added a commit that referenced this issue Mar 21, 2019
@onebytegone
fix: Escape newline/paragraph separators in JSONP responses (#36)
d57106e
onebytegone added a commit that referenced this issue Mar 21, 2019
@onebytegone
fix: Escape newline/paragraph separators in JSONP responses (#36)
8baeeb2
onebytegone added a commit that referenced this issue Mar 21, 2019
@onebytegone
fix: Escape newline/paragraph separators in JSONP responses (#36)
914b86c
onebytegone added a commit that referenced this issue Mar 22, 2019
@onebytegone
fix: Escape newline/paragraph separators in JSONP responses (#36)
6baf756
onebytegone added a commit that referenced this issue Mar 22, 2019
@onebytegone
feat: Escape newline/paragraph separators in JSONP responses (#36)
3133ea7
@onebytegone onebytegone mentioned this issue Mar 22, 2019
Merged
onebytegone added a commit that referenced this issue Apr 1, 2019
@onebytegone
feat: Escape newline/paragraph separators in JSONP responses (#36)
f681233
@onebytegone
Copy link
Contributor Author

Closed with #42.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onebytegone onebytegone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jthomerson @onebytegone