Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all translation files from Crowdin #2855

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Conversation

Nateowami
Copy link
Collaborator

@Nateowami Nateowami commented Nov 15, 2024

This change is Reviewable

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.19%. Comparing base (8061f57) to head (e39a006).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2855   +/-   ##
=======================================
  Coverage   79.19%   79.19%           
=======================================
  Files         533      533           
  Lines       30953    30953           
  Branches     5045     5050    +5     
=======================================
+ Hits        24513    24514    +1     
  Misses       5655     5655           
+ Partials      785      784    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13 of 14 files at r1, all commit messages.
Reviewable status: 13 of 14 files reviewed, 1 unresolved discussion (waiting on @Nateowami)


src/SIL.XForge.Scripture/ClientApp/src/assets/i18n/checking_ar.json line 270 at r1 (raw file):

    "save": "حفظ الإجابة",
    "your_answer": "إجابتك",
    "your_comment": "Your comment"

It seems like all of these localizations got lost. I'm guessing this is due to the update from "checking_comment_form" to "checking_input_form. I can re-add these strings and then you can update this PR.

Code quote:

    "your_comment": "Your comment"

@Nateowami
Copy link
Collaborator Author

Updated. And German has now been translated.

Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 14 of 14 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Nateowami)

@RaymondLuong3 RaymondLuong3 merged commit 6b4ba8b into master Nov 16, 2024
15 checks passed
@RaymondLuong3 RaymondLuong3 deleted the i18n/update branch November 16, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants