Reorder image fetching for GetImageFromClipboard to try PNG first

[StephenMcConnel]

This can help preserve transparency in copied images.

---

This change is 

[github-actions]

LibPalaso Tests

    35 files  ±  0     35 suites  ±0   10m 15s ⏱️ -19s
 4 824 tests ±  0  4 490 ✅ ±  0  231 💤 ± 0  103 ❌ ± 0 
10 290 runs   - 754  9 614 ✅  - 799  475 💤  - 53  201 ❌ +98 

For more details on these failures, see this check.

Results for commit 9bf7b61. ± Comparison against base commit 3fa5695.

[jasonleenaylor]

SIL.Windows.Forms/Clipboarding/WindowsClipboard.cs line 63 at r1 (raw file):

			if (dataObject == null)
				return null;
			Exception ex = null;

Not your fault, but it looks like there is no use for this variable.

[jasonleenaylor]

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, all discussions resolved

---

SIL.Windows.Forms/Clipboarding/WindowsClipboard.cs line 81 at r1 (raw file):

				catch (Exception e)
				{
					ex = e;

if the variable is removed a comment here explaining that we are intentionally ignoring it and falling back to other options would be good

[StephenMcConnel]

Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @jasonleenaylor)

---

SIL.Windows.Forms/Clipboarding/WindowsClipboard.cs line 63 at r1 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

Not your fault, but it looks like there is no use for this variable.

That's not quite true. At the end of the method, if an image is not returned, and the ex variable is not null, then the method (re)throws ex instead of returning null. But that's certainly not obvious from the default snippets shown by the reviewing tool. And I'll admit it's a marginal use. But it is a use. :-)

[jasonleenaylor]

SIL.Windows.Forms/Clipboarding/WindowsClipboard.cs line 63 at r1 (raw file):

Previously, StephenMcConnel (Steve McConnel) wrote…

That's not quite true. At the end of the method, if an image is not returned, and the ex variable is not null, then the method (re)throws ex instead of returning null. But that's certainly not obvious from the default snippets shown by the reviewing tool. And I'll admit it's a marginal use. But it is a use. :-)

Ah, I didn't expand far enough. 😄

[jasonleenaylor]

Reviewed 1 of 2 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @StephenMcConnel)