Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Framework 4.8 to all projects #1326

Merged
merged 15 commits into from
Aug 23, 2024
Merged

Added Framework 4.8 to all projects #1326

merged 15 commits into from
Aug 23, 2024

Commits on Aug 23, 2024

  1. Added Framework 4.8 to all projects 

    And fixed all warnings other than those warning about Framework 4.6.1.
    @josephmyers
    josephmyers committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    f6e6736 View commit details
    Browse the repository at this point in the history

  2. temp

    @josephmyers
    josephmyers committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    648b834 View commit details
    Browse the repository at this point in the history

  3. revert

    @josephmyers
    josephmyers committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    025bfd0 View commit details
    Browse the repository at this point in the history

  4. temp

    @josephmyers
    josephmyers committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    9fc0ddd View commit details
    Browse the repository at this point in the history

  5. Referencing explicit version of System.Memory 

    Should fix test failures on server
    @josephmyers
    josephmyers committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    63eb19e View commit details
    Browse the repository at this point in the history

  6. Explicit reference for System.Runtime.CompilerServices.Unsafe

    @josephmyers
    josephmyers committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    6d91dfe View commit details
    Browse the repository at this point in the history

  7. revert back to net48

    @josephmyers
    josephmyers committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    3aabed7 View commit details
    Browse the repository at this point in the history

  8. Made one test less brittle 

    It was requiring an error thrown by .NET code to have a very specific message, where, with later versions, a different error is thrown. The newer message is still related to the original, dealing with the path, and the updated test captures the core intent without being so picky.
    @josephmyers
    josephmyers committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    8cf2f87 View commit details
    Browse the repository at this point in the history

  9. Explicitly stripping dots from path end for comparison 

    .NET behavior changed with 4.6.2. See here for more details: https://learn.microsoft.com/th-th/dotnet/framework/migration-guide/mitigation-path-normalization

4.6.1 DirectoryInfo apparently strips ... (and maybe similar tokens, too), particularly for its FullName property, which is being used here. This changed in 4.6.2.

Assuming that the test indicates a desire for support, the simplest thing to do is to strip dots for comparison.

I also experimented with "Switch.System.IO.UseLegacyPathHandling=true" in the app.config, but this had no discernible impact and generally seems ill-advised.
    @josephmyers
    josephmyers committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    b7c02d0 View commit details
    Browse the repository at this point in the history

  10. Using framework constant

    @josephmyers
    josephmyers committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    091fba6 View commit details
    Browse the repository at this point in the history

  11. Hopeful revert of GHA (split to another PR)

    @josephmyers
    josephmyers committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    3f28ea3 View commit details
    Browse the repository at this point in the history

  12. Fix rebase

    @josephmyers
    josephmyers committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    6975339 View commit details
    Browse the repository at this point in the history

  13. Upping the timeout

    @josephmyers
    josephmyers committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    45113cb View commit details
    Browse the repository at this point in the history

  14. Ignoring a number of the long-running tests 

    A couple are still being executed on the server
    @josephmyers
    josephmyers committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    9739635 View commit details
    Browse the repository at this point in the history

  15. Added Framework 4.8 for projects overriding TargetFrameworks

    @josephmyers
    josephmyers committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    6730607 View commit details
    Browse the repository at this point in the history